Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the expectation that porter would already be installed #3033

Merged

Conversation

dgannon991
Copy link
Member

What does this change

It allows for installing porter on a fresh system from source code

What issue does it fix

Closes #3032

Notes for the reviewer

I manually tested changing the permissions on ~/.porter/porter to ensure it threw an error it the binary existed but couldn't be removed, however I do not have access to an apple mac to confirm the original issue it was attempting to fix is still OK.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: David <me@dgannon.co.uk>
@sgettys
Copy link
Contributor

sgettys commented Mar 24, 2024

Confirmed on Mac

Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution :D

@schristoff schristoff merged commit 583af5b into getporter:main Mar 24, 2024
15 checks passed
@dgannon991 dgannon991 deleted the contribfest/fix-install-on-new-system branch March 24, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running mage Install if you've never installed Porter before.
3 participants