Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ ToC #3054

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Update FAQ ToC #3054

merged 1 commit into from
Apr 2, 2024

Conversation

kichristensen
Copy link
Contributor

What does this change

Updates the ToC on the FAQ page

What issue does it fix

Closes #3053

Notes for the reviewer

An alternative solution could be to removed the ToC on the page in favor for using the one on the right provided by the theme. Please let me know what you think about that solution. The change in this PR mimics what is done on other pages, but there are pros and cons for both approaches.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Kim Christensen <kimworking@gmail.com>
@schristoff schristoff merged commit 05b1552 into getporter:main Apr 2, 2024
7 checks passed
@kichristensen kichristensen deleted the updateFaqToC branch April 6, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ table of contents are not up-to-date
2 participants