Lint error when dependency with same is defined multiple times #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having multiple dependencies with the same name results in undefined behaviour. This change introduces a lint to ensure that no dependencies share the same name. Signed-off-by: Kim Christensen <kimworking@gmail.com>
Signed-off-by: Kim Christensen <kimworking@gmail.com>
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
kichristensen
changed the title
Signed-off-by: Kim Christensen <kimworking@gmail.com>
schristoff
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Creates a lint error when multiple dependencies are specified with the same name.
What issue does it fix
Closes #3067
Notes for the reviewer
The reason the lint code is porter-102 is because of #3034 which uses porter-101
Checklist