Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable bundle reuse test #3072

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Reenable bundle reuse test #3072

merged 1 commit into from
Apr 9, 2024

Conversation

kichristensen
Copy link
Contributor

What does this change

No matter what I try I cannot get this test to fail anymore. Tried to increase the iterations to 100 without getting any failures, not in Github Actions or locally.
Based on that, the test is reenabled, and then it should be monitored if the build becomes unstable again.

What issue does it fix

Closes #2948

Notes for the reviewer

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

@kichristensen
Reenable bundle reuse test
871ca9c 
No matter what I try I cannot get this test to fail anymore. Tried to
increase the iterations to 100 without getting any fails, not in Github
Actions or locally.
Based on that the test is reenabled, and then it should be monitored
if the build becomes unstable again.

Signed-off-by: Kim Christensen <kimworking@gmail.com>
@schristoff
Copy link
Member

If this was ADO all along, I will be shocked. Otherwise, approving.

@schristoff schristoff merged commit e896bc3 into getporter:main Apr 9, 2024
15 checks passed
@kichristensen kichristensen deleted the enableBundleReuseTest branch April 10, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

@troy0820 troy0820 Awaiting requested review from troy0820 troy0820 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flakey Bundle reuse test
2 participants
@kichristensen @schristoff