Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests broken after #3005 #3128

Merged
merged 3 commits into from
May 22, 2024
Merged

Fix integration tests broken after #3005 #3128

merged 3 commits into from
May 22, 2024

Conversation

kichristensen
Copy link
Contributor

What does this change

Fix integration tests broken after #3005.

Notes for the reviewer

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

kichristensen and others added 3 commits May 22, 2024 12:05
@kichristensen
Fix integration tests broken after getporter#3005
e172933 
Signed-off-by: Kim Christensen <kimworking@gmail.com>
@kichristensen
Fix smoke test
149976d 
Signed-off-by: Kim Christensen <kimworking@gmail.com>
@kichristensen
Merge branch 'main' into fixIntegrationTest
40e1629
@kichristensen kichristensen marked this pull request as ready for review May 22, 2024 11:08
@schristoff schristoff merged commit 16f5d6a into getporter:main May 22, 2024
36 checks passed
@kichristensen kichristensen deleted the fixIntegrationTest branch May 22, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

@troy0820 troy0820 Awaiting requested review from troy0820 troy0820 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kichristensen @schristoff