Use PUBLISH_TOKEN for publishing mixins #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GITHUB_TOKEN only have access to the current repository, when publishing mixins we need permission to create commits in the packages repo. Signed-off-by: Kim Christensen <kimworking@gmail.com>
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
schristoff
approved these changes
Jun 3, 2024
|
whats up with DCO |
Signed-off-by: Kim Christensen <kimworking@gmail.com>
schristoff
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
GITHUB_TOKEN only have access to the current repository, when publishing mixins we need permission to create commits in the packages repo.
What issue does it fix
Related to #3073
Notes for the reviewer
Because the secret is only available to workflows, and requires a canary release or tagged release to be triggered, it has not been tested if the secret is still valid. Worst case it will fail just as much as it did before.
Checklist