Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard filters #3

Closed
arikfr opened this issue Oct 28, 2013 · 11 comments
Closed

Dashboard filters #3

arikfr opened this issue Oct 28, 2013 · 11 comments

Comments

@arikfr
Copy link
Member

arikfr commented Oct 28, 2013

User should be able to add a filter to the dashboard that will be applied to all the queries of the widgets displayed.

Such filters can be:

  • date selection
  • values selection

TBD: explain about the two possible implementation strategies.

@arikfr
Copy link
Member Author

arikfr commented Oct 30, 2013

An example of where the strategy of filtering on the "client side" won't work: when doing a query with limit on the results. For each filter the top results will be different.

@arikfr
Copy link
Member Author

arikfr commented Mar 18, 2014

Related: #140 .

arikfr pushed a commit that referenced this issue May 13, 2014
@arikfr arikfr modified the milestones: v0.4, Next Oct 21, 2014
@arikfr
Copy link
Member Author

arikfr commented Dec 12, 2014

One comment though - the values for the filter are the union of all relevant filter values in the dashboard.
The problem with that is that in case one visualization/query has no data points for this filter, then the dashboard-wide filter will not affect it when setting the missing value, which can be quite confusing for a user (as all widgets on the dashboard will be for filter value A, while some other widget will be for value B)
I think a better behavior would be to clearly mark in the visualization/table that there are no relevant data points.

@indupulikkot
Copy link

HI arik,
As you said these filters are not working as expected.
'the values for the filter are the union of all relevant filter values in the dashboard.'

I our case, the global filter is taking first chart's filter value even if there are more values in the filter for second chart. So basically it is not doing union.

Please suggest

@RichardLitt
Copy link

Thanks for logging that, @indupulikkot. Can you provide a minimal example that we can look at to fix this?

@indupulikkot
Copy link

Iam attaching a screenshot with the issue description. Please review and suggest a fix for this. Our project is already live and this persists as an issue for us.
redash global filter issue.docx

@RichardLitt
Copy link

RichardLitt commented Jan 19, 2018

@indupulikkot Thanks for attaching a screenshot, and for letting us know that this is potentially urgent for you.

The open source version of Redash is a community project and comes with no warranties or support. We'll fix this issue when we can or when it becomes relevant to our customers, but other issues have a higher priority right now. The fastest way for this to be fixed would most likely be for you to suggest a pull request, which would really be great. Let us know if it's something you need help with, and will review the PR and try and help you land it.

If you need commercial support for your Redash deployment, you should use the SaaS version. In some cases we might consider engaging in a support contract for an on-premises deployment, but this is discussed on a case-by-case basis.

@arikfr
Copy link
Member Author

arikfr commented Feb 4, 2018

@RichardLitt I updated your comment to better reflect the actual situation (saying Redash is mostly volunteer run is not accurate).

@indupulikkot FYI.

@arikfr
Copy link
Member Author

arikfr commented Feb 4, 2018

I'm closing this, as most of what described here can be achieved with parameters.

If there are specific issues with filters or parameters on dashboards, we should open more granular issues.

@arikfr arikfr closed this as completed Feb 4, 2018
@RichardLitt
Copy link

Thanks @arikfr!

@indupulikkot
Copy link

May I know why this issue is closed? C ould you please help us to fix this as we do not require parameters.

harmy pushed a commit to harmy/redash that referenced this issue Jun 28, 2018
* commit '5bad35d409485f450831dcd57a315bd0c067d563':
  code refactoring
  forgot to change circleci username in the artifacts url
  change ci address to my own
ranbena added a commit that referenced this issue Mar 13, 2019
ranbena added a commit that referenced this issue Oct 31, 2019
ranbena added a commit that referenced this issue Oct 31, 2019
restyled-io bot pushed a commit that referenced this issue Apr 19, 2021
restyled-io bot pushed a commit that referenced this issue Jul 27, 2021
stevenhao added a commit to stevenhao/redash that referenced this issue Feb 2, 2022
* try making multi-filters default to all

haven't tested

* Update query-result.js

* Update query-result.js
devin-aot pushed a commit to devin-aot/redash that referenced this issue Nov 4, 2022
show months in 2 digit numbers instead of name
junnplus referenced this issue in junnplus/redash May 10, 2023
ci: migrate to github workflow ci
guidopetri pushed a commit that referenced this issue Jul 21, 2023
* Parameter feedback - #3 Added in Widgets

* Added cypress tests

* Making sure widget-level param is selected

* Parameter feedback - #4 Added in Dashboard params (#4321)

* Parameter feedback - #4 Added in Dashboard params

* Added cypress test

* Moved to service

* Parameter feedback - #5 Unsaved indication (#4322)

* Parameter feedback - #5 Unsaved indication

* Added ANGULAR_REMOVE_ME

* Added cypress test

* Fixed percy screenshot

* Some code improvements

* Parameter input feedback - #6 Better value normalization (#4327)
guidopetri pushed a commit that referenced this issue Jul 21, 2023
* Parameter feedback - #2 Client errors in query page

* Added cypress test

* Fixed percy screenshot

* Safer touched change

* Parameter feedback - #3 Added in Widgets (#4320)

* Parameter feedback - #3 Added in Widgets

* Added cypress tests

* Making sure widget-level param is selected

* Parameter feedback - #4 Added in Dashboard params (#4321)

* Parameter feedback - #4 Added in Dashboard params

* Added cypress test

* Moved to service

* Parameter feedback - #5 Unsaved indication (#4322)

* Parameter feedback - #5 Unsaved indication

* Added ANGULAR_REMOVE_ME

* Added cypress test

* Fixed percy screenshot

* Some code improvements

* Parameter input feedback - #6 Better value normalization (#4327)
@deecay deecay mentioned this issue Sep 20, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants