Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical scroll in query results is broken #7127

Closed
denisov-vlad opened this issue Aug 20, 2024 · 7 comments
Closed

Vertical scroll in query results is broken #7127

denisov-vlad opened this issue Aug 20, 2024 · 7 comments

Comments

@denisov-vlad
Copy link
Member

Issue Summary

Currently, on the latest commit we cannot scroll down in query results.

Steps to Reproduce

  1. Run query with more than 25 rows in result
  2. Save it and try to scroll down

Any other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?

Technical details:

  • Redash Version: #58a7438
  • Browser/OS: Chrome 127.0.6533.120 / Windows 11
  • How did you install Redash: self-hosted via docker-compose
@thiborgesnvs
Copy link

thiborgesnvs commented Aug 21, 2024

We are facing the same problem here on our environment

If you go to chrome developers tool you will be able to see the overflow-x frame is being showed as hidden

If you manually change this option on developer tool on chrome the scroll down will appear

I have no idea how to fix on the code

@justinclift
Copy link
Member

Ouch, that doesn't sound good at all.

@denisov-vlad It's possible my update of rapidjson broke it yesterday somehow, though that's kind of surprising. Any idea if the commit on master before yesterday's one has the same problem?

@thiborgesnvs Which version of Redash are you using?

@denisov-vlad
Copy link
Member Author

I suppose this PR has broken it: #7019

We switched to version before that, and everything works fine. Also, that PR was the reason why I decided to update Redash :)

@justinclift
Copy link
Member

Thanks @denisov-vlad. 😄

@eradman
Copy link
Collaborator

eradman commented Aug 21, 2024

I am working on a fix for this regression, I will put up a pull request for review tomorrow.

@justinclift
Copy link
Member

Thanks heaps @eradman. 😄

@justinclift
Copy link
Member

@denisov-vlad We've just merged @eradman's PR which reverts that commit. That should at least solve the immediate problem and we can follow up later for a better approach to improve fixed column layouts. 😄

eradman added a commit to StarfishStorage/redash that referenced this issue Aug 27, 2024
This reverts commit ebb0e2c.

This feature disabled vertical scroll in query results:
getredash#7127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants