-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical scroll in query results is broken #7127
Comments
We are facing the same problem here on our environment If you go to chrome developers tool you will be able to see the overflow-x frame is being showed as hidden If you manually change this option on developer tool on chrome the scroll down will appear I have no idea how to fix on the code |
Ouch, that doesn't sound good at all. @denisov-vlad It's possible my update of rapidjson broke it yesterday somehow, though that's kind of surprising. Any idea if the commit on @thiborgesnvs Which version of Redash are you using? |
I suppose this PR has broken it: #7019 We switched to version before that, and everything works fine. Also, that PR was the reason why I decided to update Redash :) |
Thanks @denisov-vlad. 😄 |
I am working on a fix for this regression, I will put up a pull request for review tomorrow. |
Thanks heaps @eradman. 😄 |
@denisov-vlad We've just merged @eradman's PR which reverts that commit. That should at least solve the immediate problem and we can follow up later for a better approach to improve fixed column layouts. 😄 |
This reverts commit ebb0e2c. This feature disabled vertical scroll in query results: getredash#7127
Issue Summary
Currently, on the latest commit we cannot scroll down in query results.
Steps to Reproduce
Any other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?
Technical details:
The text was updated successfully, but these errors were encountered: