Bring back filters if dashboard filters are enabled #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you add a screenshot of how it looks now with the filters? |
|
@arikfr Here you go: http://puu.sh/oUW1G/a5d2183bbc.png |
|
@arikfr Anything blocking you from merging? |
|
I was thinking of adjusting the look of it, but decided to merge as is and handle it when I add support for parameters UI in dashboards. |
|
Thanks! |
simo7
pushed a commit
to pubnative/redash
that referenced
this pull request
Sep 22, 2016
Bring back filters if dashboard filters are enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the redesign, dashboard filters were accidentally removed in this commit. 44f8ccf
This one line PR fixes it :)