Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: rate limit the login page #1373

Merged
merged 1 commit into from
Nov 20, 2016

Conversation

AntoineAugusti
Copy link
Contributor

This is related to #115

Straightforward use of Flask limiter https://flask-limiter.readthedocs.io

@arikfr arikfr changed the title Rate limit the login page Add: rate limit the login page Nov 2, 2016
@AntoineAugusti
Copy link
Contributor Author

Added a test + squashed

@@ -81,6 +81,7 @@ def forgot_password(org_slug=None):


@routes.route(org_scoped_rule('/login'), methods=['GET', 'POST'])
@limiter.limit("50/hour")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this configurable.

@AntoineAugusti
Copy link
Contributor Author

Added a conf variable

@AntoineAugusti
Copy link
Contributor Author

@arikfr Anything blocking this PR for being merged?

@arikfr
Copy link
Member

arikfr commented Nov 8, 2016

Sorry for not mentioning earlier -- I'm no longer merging stuff until I finish with the 0.12 release (#1378). Once it's out, I will merge it.

@arikfr arikfr added this to the v1.0.0 milestone Nov 8, 2016
@arikfr
Copy link
Member

arikfr commented Nov 20, 2016

Hi, @AntoineAugusti - because I removed the docs folder, you need to rebase. Thanks.

@AntoineAugusti
Copy link
Contributor Author

@arikfr Rebased and squashed 👍

@arikfr arikfr merged commit 037d196 into getredash:master Nov 20, 2016
@arikfr
Copy link
Member

arikfr commented Nov 20, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants