Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added global params to dashboards #1483

Closed
wants to merge 1 commit into from

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Dec 22, 2016

I think master is currently in a broken state, so I couldn't actually make this change there, but I did start from the last release v0.12.0.b2449 and made this change. I can't propose a PR from a tag or propose a new branch though.

If you prefix a parameter with $ then when viewing it at the dashboard level it gets promoted to be a dashboard level param and queries can share these params.

Feature request here: https://discuss.redash.io/t/add-ui-for-query-params-at-dashboard-level/236/8

Video of the feature here: https://goo.gl/photos/UEjDv3fDhCrb2AnU6

I guess in order to merge this, we'd need a new branch for a v0.13.0 release or something similar. When master is stable and I would be more than happy to add this there too (and make it slightly less hacky). Our team needs this to adopt redash, and we don't want to be stuck on an old version 😄

@rockwotj
Copy link
Contributor Author

There needs to be some way to update the global params list when a widget is added or removed. Any thoughts on this? Should there be a watch on the length of widgets?

@arikfr
Copy link
Member

arikfr commented Dec 22, 2016

Watch on widgets will work, although it's bad for performance. On the master branch, you can just do this in a callback after the add widget dialog is closed.

@rockwotj
Copy link
Contributor Author

SG

@rockwotj rockwotj closed this Dec 22, 2016
@rockwotj rockwotj deleted the dashboard-params branch December 22, 2016 21:40
@rockwotj rockwotj restored the dashboard-params branch December 23, 2016 01:31
@rockwotj rockwotj deleted the dashboard-params branch January 3, 2017 02:16
@rockwotj rockwotj restored the dashboard-params branch January 3, 2017 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants