-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the X and Y tick format to be customized #6370
Conversation
@gabrieldutra Do you have time & interest to look over this PR? 😄 |
Codecov Report
@@ Coverage Diff @@
## master #6370 +/- ##
=======================================
Coverage 60.78% 60.78%
=======================================
Files 153 153
Lines 12527 12529 +2
Branches 1701 1701
=======================================
+ Hits 7614 7616 +2
Misses 4687 4687
Partials 226 226 |
CC @litao3rd |
Looks good! |
I'm not going to add that to this change, but this is a good idea to keep in mind as an incremental improvement. |
Cool. Seems like everything with this PR is happy. Is it ready to merge now, or are you still tweaking it a bit? 😄 |
This is ready to go. Merging |
Allow the format of each axis to be customzied using a D3 format string
Numbers: https://d3-wiki.readthedocs.io/zh_CN/master/Formatting/
Date/Time: https://d3-wiki.readthedocs.io/zh_CN/master/Time-Formatting/
What type of PR is this?
Description
The database will save these in
visualizations.options
Specifying a D3 format
How is this tested?
Related Tickets & Documents
#3215
Separate documentation needs to be added since there is no numbro/moment.js equivalent translation to D3 syntax.
Plotly does not allow a custom function to be defined for axis formatting.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Old Behavior
New Axis Formatting using
Y: s
X: %B %d