Add new connection options in MySQL #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6538 +/- ##
=======================================
Coverage 61.88% 61.88%
=======================================
Files 158 158
Lines 12965 12965
Branches 1770 1770
=======================================
Hits 8024 8024
Misses 4666 4666
Partials 275 275
|
guidopetri
approved these changes
Oct 19, 2023
|
Thanks for these changes @adrianoapj ! Hopefully the e2e tests pass on the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
This PR adds some new connection options to the MySQL query runner, I added this because when trying to connect to a PlanetScale instance, I got some errors and it required to use these extra options to work.
How is this tested?
I changed the query runner, so we had some small changes in the UI when adding a MySQL database which I tested and I also tried to connect to a PlanetScale instance using it and it worked. I also ran unit tests and E2E tests to ensure nothing broke, however not all tests with Cypress passed (at least locally using my MacBook Air M1), but I don't think it's related to the changes I made.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)