Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter widget results to fix tests during repeatable execution #6693

Conversation

AndrewChubatiuk
Copy link
Contributor

What type of PR is this?

fixed one of tests, which fails, when running cypress tests without db recreation

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.82%. Comparing base (af0773c) to head (3a34eb9).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6693   +/-   ##
=======================================
  Coverage   63.82%   63.82%           
=======================================
  Files         161      161           
  Lines       13060    13060           
  Branches     1803     1803           
=======================================
  Hits         8335     8335           
  Misses       4425     4425           
  Partials      300      300           

@AndrewChubatiuk AndrewChubatiuk changed the title filter widged results to fix tests during repeatable execution filter widget results to fix tests during repeatable execution Jan 4, 2024
@AndrewChubatiuk AndrewChubatiuk force-pushed the filter-widget-results-to-fix-repeatable-tests-execution branch 2 times, most recently from c1405de to 1e022c4 Compare January 9, 2024 09:15
@AndrewChubatiuk
Copy link
Contributor Author

@justinclift could you please review this MR?

@AndrewChubatiuk AndrewChubatiuk mentioned this pull request Jan 18, 2024
10 tasks
@AndrewChubatiuk AndrewChubatiuk force-pushed the filter-widget-results-to-fix-repeatable-tests-execution branch from 1e022c4 to 3a34eb9 Compare April 10, 2024 12:46
Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concept of this seems fine. 😄

@justinclift justinclift enabled auto-merge (squash) April 10, 2024 12:47
@justinclift
Copy link
Member

Hmmm, looks like you're still working on this. Um, ping me when you're happy with it? 😄

@AndrewChubatiuk
Copy link
Contributor Author

just rebased it, it's ready to be merged

@justinclift justinclift merged commit 776703f into getredash:master Apr 10, 2024
13 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the filter-widget-results-to-fix-repeatable-tests-execution branch April 10, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants