convert query result back to text #6713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6713 +/- ##
===========================================
+ Coverage 0 63.38% +63.38%
===========================================
Files 0 162 +162
Lines 0 13176 +13176
Branches 0 1819 +1819
===========================================
+ Hits 0 8351 +8351
- Misses 0 4534 +4534
- Partials 0 291 +291
|
This was referenced Jan 17, 2024
Merged
|
Thanks for investigating this @AndrewChubatiuk. 😄 It looks like might need a bit more work before things are totally happy though: #6706 (comment) |
eradman
requested changes
Jan 17, 2024
AndrewChubatiuk
force-pushed
the
convert-query-result-data-to-text
branch
from
383c810
to
fe8da5d
Compare
eradman
approved these changes
Jan 17, 2024
|
Cool, lets merge this then. Thanks for getting this done @AndrewChubatiuk. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Convert QueryResult data column back to text due to a limit of JSON(10MB) and JSONB(255MB) column type size
Description
Removed from migrations conversion of QueryResult.data to JSONB, and added custom JsonText type, which is actually a copy of removed PseudoJson type
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)