-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClickHouse query runner: fixed error message #6764
ClickHouse query runner: fixed error message #6764
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6764 +/- ##
==========================================
- Coverage 63.43% 63.42% -0.01%
==========================================
Files 163 163
Lines 13200 13203 +3
Branches 1822 1823 +1
==========================================
+ Hits 8373 8374 +1
- Misses 4530 4531 +1
- Partials 297 298 +1
|
@getredash/maintainers could you merge it please? Now we don't see any messages on errors, it's difficult to debug errors in SQL. |
Your branch has some conflict. I updated your branch, if CI have pass, i will merge it. Don't worry. |
Looks like it's passing enough. Lets merge it. 😄 |
Thanks! |
What type of PR is this?
Description
Since ~ 23.10 ClickHouse returns 200 status code for all types of requests, but adds
exception
in response. This PR adds conditions to check for this key.How is this tested?
Related Tickets & Documents
#6756
Mobile & Desktop Screenshots/Recordings (if there are UI changes)