Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uncaught rejection promise error in Edit Visualization Dialog Modal #6794

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

arungovindm2001
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

A fix to Uncaught Promise Error exception when clicking No in Edit Visualization Dialog modal

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

#6793

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.43%. Comparing base (34723e2) to head (6aa621a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6794   +/-   ##
=======================================
  Coverage   63.43%   63.43%           
=======================================
  Files         163      163           
  Lines       13200    13200           
  Branches     1822     1822           
=======================================
  Hits         8373     8373           
  Misses       4530     4530           
  Partials      297      297           

@justinclift
Copy link
Member

Thanks @arungovindm2001. It looks like the restyled check is failing, and wants the formatting to be slightly different.

Are you ok to get that done? 😄

@arungovindm2001
Copy link
Contributor Author

arungovindm2001 commented Mar 4, 2024

Thanks @arungovindm2001. It looks like the restyled check is failing, and wants the formatting to be slightly different.

Are you ok to get that done? 😄

I have done the restyling. Thanks! 😄

Copy link
Collaborator

@eradman eradman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@justinclift justinclift merged commit d554136 into getredash:master Mar 7, 2024
13 checks passed
@justinclift
Copy link
Member

Cool, merged. Thanks for getting this done @arungovindm2001. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants