-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pydeps Makefile target for installing Python dependencies #6890
Conversation
17f1e34
to
2f919a1
Compare
Once this is merged, I'll update our wiki page to use this new
|
have you looked at https://python-poetry.org/docs/managing-dependencies/ for this purpose? |
Oh, we only added the specific I suspect we could drop the version numbers now, as from rough memory we've already upgraded the ones in the poetry file past those anyway. Hmmm, I can probably check that pretty easily. Gimme a bit of time and I'll try things out without the hard coded numbers there. 😄 |
This combines the manual steps needed for installing the Python dependencies into a single Makefile target.
a282306
to
ce5e6f1
Compare
@AndrewChubatiuk Finally had a few spare minutes to test this properly. We don't need the hard coded version numbers any more after all, so those have been removed. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @AndrewChubatiuk. 😄 |
What type of PR is this?
Description
This combines the manual steps needed for installing the Python dependencies into a single Makefile target, simplifying the dev environment setup process a bit.
How is this tested?
This has also been manually tested to ensure the new
pydeps
Makefile target runs the same commands as the documented manual steps.