Use staticPath var to fetch unsupportedRedirect.js #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Webpack configuration for locating this asset in the same way that client/app/index.html does. This code path is when REDASH_MULTI_ORG=true.
|
There's a bit of a queue of CI tests running at the moment. Once the ARM64 MSSQL ODBC one goes in, we can do this one next. 😄 |
|
@eradman Merged. Looks like you're working on getting the |
|
Yes, it turns out that besides the multi-tenet hosting, MULTI_ORG feature is very useful when setting up an instance of behind a web server with a custom URL, such as |
|
Yeah, I can see how that'd be super useful for integrating into existing web interface setups. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Use Webpack configuration for locating this asset in the same way that
client/app/index.htmldoes.How is this tested?
(1) Enable MULTI_ORG in .env
(2) Update the slug for the default organization
(3) change
baseHref and staticPathinwebpack.config.js(4) run
make build(5) verify that accessing the site at
http://localhost:5001/redash/works