Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyodbc from 4.0.28 to 5.1.0 #6962

Merged
merged 2 commits into from
May 14, 2024
Merged

Bump pyodbc from 4.0.28 to 5.1.0 #6962

merged 2 commits into from
May 14, 2024

Conversation

ehooi
Copy link
Contributor

@ehooi ehooi commented May 11, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Bump pyodbc from 4.0.28 to 5.1.0
This major version upgrade has NO api changes.

Below is copied from pyodbc release notes.


5.0.0 Release

This is the first 3.x only pyodbc release, supporting Python 3.8-3.12.

The API is backwards compatible, so previous Python 3 products using pyodbc should not need any changes.

Please note that macOS ARM / Apple Silicon binary builds have been problematic due inconsistencies in the way unixODBC libraries can be installed. Please see the issues and discussions.


5.0.1 with fix for Azure tokens / binary attrs_before

This is a bug fix for 5.0.0 that restores the ability to pass bytes objects in the attrs_before parameter when connecting. This is often used for Azure with a token. Issue mkleehammer/pyodbc#1289


5.1.0 with Mac ARM (M1 & M2) binaries

Mac M1 & M2 binaries are available going forward.

GitHub added new Mac ARM action runners which is what we use to build each release.

Thanks to @keitherskine who made all this happen. Not only did he write the original release code for all of the other versions, he jumped on the new Mac runner as soon as it was available.

I'd also like to thank the many people working through the Mac binary confusion, testing and providing work arounds until this runner was available: @Carreau @ndmlny-qs @jordantshaw @gabalafou @v-chojas and many others on the Issue.

If you are a Mac user, please let us know how this works for you.


How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.83%. Comparing base (1b946b5) to head (0deaa55).
Report is 3 commits behind head on master.

❗ Current head 0deaa55 differs from pull request most recent head e61e9e8. Consider uploading reports for the commit e61e9e8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6962   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files         161      161           
  Lines       13094    13094           
  Branches     1814     1814           
=======================================
  Hits         8359     8359           
  Misses       4432     4432           
  Partials      303      303           

@justinclift
Copy link
Member

Cool, this looks useful and seems like it'll upgrade without causing issues.

We can't merge it for a little bit (few days) as we're taking some time to figure out a complicated roll back (details here). But once that's done, this seems like it should slot right in. 😄

Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @ehooi. 😄

@justinclift justinclift enabled auto-merge (squash) May 14, 2024 15:57
@justinclift justinclift merged commit f3a3236 into getredash:master May 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants