Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "show pg and athena column comments and table descriptions as … #6971

Merged
merged 1 commit into from
May 16, 2024
Merged

Revert "show pg and athena column comments and table descriptions as … #6971

merged 1 commit into from
May 16, 2024

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented May 15, 2024

What type of PR is this?

  • Revert

Description

This commit did not sort tables properly by schema, then name.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually

Related Tickets & Documents

#6964

@eradman
Revert "show pg and athena column comments and table descriptions as …
a564fb1 
…antd tooltip if they are defined (getredash#6582)"

This reverts commit c12d450.

This commit did not sort tables properly by schema, then name
@justinclift
Copy link
Member

For reference, the original PR this is reverting is #6582.

@justinclift
Copy link
Member

@gaecoli Would you be ok to look over this one as well? 🙏

@gaecoli
Copy link
Member

gaecoli commented May 16, 2024

@gaecoli Would you be ok to look over this one as well? 🙏

What happened? Why should this be reverted?

@eradman
Copy link
Collaborator Author

eradman commented May 16, 2024

@gaecoli Would you be ok to look over this one as well? 🙏

What happened? Why should this be reverted?

The list of tables is no longer sorted by schema and table name in the query editor.

We can, of course fix this but there were changes in this commit that I do not understand.

@gaecoli
Copy link
Member

gaecoli commented May 16, 2024

@gaecoli Would you be ok to look over this one as well? 🙏

What happened? Why should this be reverted?

The list of tables is no longer sorted by schema and table name in the query editor.

We can, of course fix this but there were changes in this commit that I do not understand.

Ok.

gaecoli
gaecoli approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@gaecoli gaecoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaecoli gaecoli merged commit 10a46fd into getredash:master May 16, 2024
11 checks passed
@justinclift
Copy link
Member

Thanks @eradman and @gaecoli. 😄

@eradman eradman deleted the show-column-comments branch May 16, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaecoli gaecoli gaecoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eradman @justinclift @gaecoli