-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Python 3.10 #6991
Update to Python 3.10 #6991
Conversation
The rough idea we've sort of had is that we'd stick with Python 3.8 while it's not deprecated. That being said, perhaps we should revisit that idea? (Personally I don't develop using Ubuntu any more either. 😉) |
Imported from getredash#6991 for proper Python 3.10 support.
I have tested this change extensively, and it is working well. The bulk of the work here is to update to sqlalchemy-utils, which is a significant change because they dropped features that Redash requires. @justinclift would you like to take the update to Python 3.10 as a separate PR? |
U guess you're meaning to break this PR into to, one for the sqlalchemy-utils update and one for stuff specifically to upgrade Python to 3.10? Was thinking about this a bit more the other day. I guess my real concern about updating to Python 3.10 is whether that will create issues for any of the data source libraries we're using? I'm guessing "probably not", but I'd like to make sure it doesn't. Or at least make sure we fix any problems it'd introduce. @arikfr probably has thoughts about it too, as it'll have project wide ramifications. If it turns out completely fine, then I don't have any objections to moving to Python 3.10. 😄 |
At Starfish Storage we have been running Redash patched to run with Python 3.10 for about two years--in fact we have to for FIPS compliance. It could be that one of the data source libraries does not work properly with 3.10, but we have not encountered this yet. |
Sounds like it's probably fairly safe then. 😄 |
Conflicts for |
Updated from Python 3.8 to 3.10. Python 3.10 is the default for Ubuntu 22. This change necessitated upgrading to SQLAlchemy_Utils 0.38.3, and importing the sort_query function from an older version of SQLAlchemy_Utils because it was dropped in newer versions.
Merged before the poetry lock file changes again. 😄 |
What type of PR is this?
Description
Updated from Python 3.8 to 3.10. Python 3.10 is the default for Ubuntu 22. This change necessitated upgrading to SQLAlchemy_Utils 0.38.3, and importing the sort_query function from an older version of SQLAlchemy_Utils because it was dropped in newer versions.
How is this tested?