Support Arbitrary Catalog IDs on Athena Data Source #7059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaniwaki
commented
Jul 14, 2024
3 tasks
dtaniwaki
changed the title
dtaniwaki
force-pushed
the
catalog-ids
branch
5 times, most recently
from
4541564
to
f8de7d4
Compare
|
The text looks good enough as it, but I think it could be made more explicit by changing it to something like this: |
|
I updated the text. Thank you! |
|
LGTM. Thanks :) |
lucydodo
approved these changes
Jul 18, 2024
justinclift
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Looks good to me. Thanks for contributing this @dtaniwaki. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Currently, a schema list on an Athena data source is only based on the default catalog. If we have an Athena role which is allowed to use glue catalogs of cross accounts, we can still query them by the runner, but no schema of the other catalogs are listed on the UI.
How is this tested?
I tested the following test cases.
And confirmed that I can see expected schema on the UI.
Related Tickets & Documents
It's related to #5682
Mobile & Desktop Screenshots/Recordings (if there are UI changes)