Add line and scatter as new graphs

[christophervalles]

This PR adds two new graph types and allows the user to change the graph type using a selector. The new graphs added is line and scatter. We are still missing a way to specify the graph type to be used for widgets. Maybe that could be part of the info for a saved query or could be specified on the SQL itself.

[arikfr]

@christophervalles First, thanks! It's great to see that you found the project valuable enough to contribute back code. As for the code itself, I have some good news and some bad news.

I will start with the bad news first: I'm not going to merge this.
The good news: issue #2 ("Visualizations workflow & object") is already in progress, and looks like @amirnissim is going to release the first iteration of it today. The functionality he already implemented cover this PR and gives you the ability to place different chart types on the dashboards.

Also, we're going to move away from specifying chart options in SQL and let the user define those options when selecting the chart (visualization) type. This is something that won't be released as part of the first iteration, but will probably come soon.

Let me know if you have any comments/questions/requests.

[christophervalles]

Hi @arikfr, no issue at all. I will maintain this on my fork until the work on issue #2 is released and then I will just remove my part (as I need it working now). But good to know that is ongoing. Sorry to not check the issues/pr about this.

[arikfr]

@christophervalles no worries.

Btw, did you get the email I sent you?

[christophervalles]

Yes, I got it. I'll reply today as soon as possible ;)

On Tue, Feb 4, 2014 at 2:32 PM, Arik Fraimovich notifications@github.comwrote:

@christophervalles https://github.com/christophervalles no worries.

Btw, did you get the email I sent you?

Reply to this email directly or view it on GitHubhttps://github.com//pull/72#issuecomment-34064062
.