Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Pin cocoapods version #496

Merged
merged 13 commits into from
Oct 24, 2023
Merged

ref: Pin cocoapods version #496

merged 13 commits into from
Oct 24, 2023

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Oct 23, 2023 •
edited
Loading

Pinning cocoapods and activesupport versions.
This is a temporary solution for this problem .
We should remove the activesupport pinning after cocoapods is fixed.

asottile-sentry
asottile-sentry reviewed Oct 23, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
philipphofmann
philipphofmann approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, LGTM.

Gemfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
asottile-sentry
asottile-sentry requested changes Oct 23, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
asottile-sentry
asottile-sentry reviewed Oct 23, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
asottile-sentry
asottile-sentry reviewed Oct 23, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Gemfile Outdated Show resolved Hide resolved
asottile-sentry
asottile-sentry reviewed Oct 23, 2023
View reviewed changes
.dockerignore Outdated Show resolved Hide resolved
asottile-sentry
asottile-sentry approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

philipphofmann
philipphofmann reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brustolin.

Gemfile Outdated Show resolved Hide resolved
@brustolin @philipphofmann
Update Gemfile
ad32377 
Co-authored-by: Philipp Hofmann <ph.hofmann@pm.me>
@brustolin brustolin merged commit 6aecd05 into master Oct 24, 2023
8 checks passed
@brustolin brustolin deleted the fix/pin-cocoapod-version branch October 24, 2023 07:42
@kevnm67 kevnm67 mentioned this pull request Oct 24, 2023
Closed
@philipphofmann philipphofmann mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@asottile-sentry asottile-sentry asottile-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brustolin @philipphofmann @asottile-sentry