test: zip extraction #519
Closed
test: zip extraction #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,16 +1,18 @@ | |||
| import * as fs from 'fs'; | |||
There was a problem hiding this comment.
(can't comment on the zip file) -- would it be possible to use a smaller zip -- 1MB is quite hefty to be part of the repository forever!
|
can't reproduce the issue with a given zip file at the moment, I'll leave that to someone facing this next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test case so that in the future when NodeJS is updated and it breaks zip extraction, tests would capture that.
Related: #518
Update: I've actually tried switching to node20 in the repo and the test still passes so not what I was hoping for. Although it still is good to have a test so I guess the PR is still valid.