This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
Add ttid/ttfd contribution flags to span data convention #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
markushi
commented
Apr 25, 2024
| @@ -43,6 +43,8 @@ Below describes the conventions for the Span interface for the `data` field on t | |||
| | `frames.slow` | int | The number of slow frames rendered during the lifetime of the span. | `2` | | |||
| | `frames.frozen` | int | The number of frozen frames rendered during the lifetime of the span. | `1` | | |||
| | `frames.delay` | number | The sum of all delayed frame durations in seconds during the lifetime of the span. For more information see <Link to="/sdk/performance/frames-delay/">frames delay</Link>. | `1.3246` | | |||
| | `contributes_ttid` | boolean | Whether the span execution contributed to the TTID (time to initial display) metric. | `true` | | |||
There was a problem hiding this comment.
to preserve data, SDKs should probably only set the flag if it's value is true.
There was a problem hiding this comment.
could we add a namespace for this? like mobile.contributes_ttid?
There was a problem hiding this comment.
Actually I guess ttid could apply for gaming/browser in the future, could we make it ui.contributes_ttid instead?
There was a problem hiding this comment.
I agree with ui.contributes_ttid. I think we could start a new category as mobile for this.
narsaynorath
approved these changes
May 2, 2024
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ui.ui.contributes_to_ttidandui.ui.contributes_to_ttfdto the span data bag. The SDKs should set those flags on all spans which contribute to ttid / ttfd.I'm still not 100% happy with the naming, if you have something better in mind, feel free to suggest!
Based on previous discussions here: https://www.notion.so/sentry/span-contribution-9b5a0979a81645789db6877593729cf4
Java impl: getsentry/sentry-java#3386
Preview deeplink: https://develop-git-feat-ttidttfdcontributingflags.sentry.dev/sdk/performance/span-data-conventions/#ui