Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Slack integration guide #73

Conversation

phyzical
Copy link
Contributor

@phyzical phyzical commented Jul 3, 2020

  • added quickstart to readme
  • added links to new slack integration doc page
  • added images incase they are removed from discord cdn
  • added guide contents and added chunk on missing config
  • added init command to simplify things further

Addresses things mentioned in getsentry/sentry#19446

* added quickstart to readme
* added links to new slack integration doc page
* added images incase they are removed from discord cdn
* added guide contents and added chunk on missing config
@vercel
Copy link

vercel bot commented Jul 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/develop/q2n6sn33z/sentry.dev
✅ Preview: https://develop-git-fork-phyzical-phyzical-featadding-sla-9bd540.sentry.dev

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this! Looks like the process is quite long (I got tired when I was reading this :D) Maybe this can serve as as an indicator to find ways to make the flow easier.

src/docs/integrations/slack/index.mdx Outdated Show resolved Hide resolved
src/docs/integrations/slack/index.mdx Show resolved Hide resolved
@phyzical
Copy link
Contributor Author

phyzical commented Jul 8, 2020

no worries :) figured i could do something to give back only took 10 minutes of my time after all

@BYK
Copy link
Member

BYK commented Jul 8, 2020

On your court @MeredithAnya or @scefali as the Ecosystem team.

@scefali
Copy link
Contributor

scefali commented Jul 8, 2020

Everything looks good to me! Just left one comment about the signing secret

phyzical and others added 4 commits July 9, 2020 09:19
rejig on legacy-app wording
* added a rejig to suggesting to use signing secret isntead of verification token
@phyzical
Copy link
Contributor Author

phyzical commented Jul 9, 2020

hey @MeredithAnya @scefali

Ready for review whenever :)

@scefali scefali merged commit 60b574d into getsentry:master Jul 9, 2020
@scefali
Copy link
Contributor

scefali commented Jul 9, 2020

@phyzical Thanks for your help! Merged!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants