Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Do not record errors for terminals #924

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Do not record errors for terminals #924

wants to merge 3 commits into from

Conversation

mitsuhiko
Copy link
Member

This will not record errors by default if a tty is detected. If you
want to record anyways do not register the default hook and manually
install it with the flag flipped.

@dcramer
Copy link
Member

dcramer commented Dec 5, 2016

offline conversation around this was how noisy things like custom scripts are when you're fucking around from a terminal

+1

@mitsuhiko
Copy link
Member Author

@dcramer added test

@mattrobenolt
Copy link
Contributor

Why not just entirely skip installing the hook if it's not a tty? Is it possible that stdin being a tty could change while the process is running?

@mitsuhiko
Copy link
Member Author

mitsuhiko commented Dec 14, 2016

@mattrobenolt i don't know if it can change on the same stream but there are a few cases where this can be an issue:

  • you fork off a child and close the input stream
  • someone patches sys.stdin at runtime

@ryanhiebert
Copy link

ryanhiebert commented Feb 8, 2018

We've been going nuts with typos on an interactive console causing emails from Sentry, and the delay that sending the message causes when we do hit errors from the console before it shows us the error interactively. We would really appreciate this feature!

@ashwoods ashwoods self-assigned this Feb 8, 2018
@ashwoods ashwoods added this to the 7.0 milestone Feb 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants