feat(spans): tag user.geo.subregion on mobile spans (#3927)

Work toward getsentry/sentry#75230 This PR allows mobile spans to be filtered down by subregion too. Anywhere we tag `device.class`, we also should also tag `user.geo.subregion` for this to work
getsentry · Aug 14, 2024 · 50cf4f9 · 50cf4f9
1 parent f2980a8
commit 50cf4f9
Show file tree

Hide file tree

Showing 4 changed files with 114 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,7 @@
 - Extract client sdk from transaction into profiles. ([#3915](https://github.com/getsentry/relay/pull/3915))
 - Extract `user.geo.subregion` into span metrics/indexed. ([#3914](https://github.com/getsentry/relay/pull/3914))
 - Add `last_peek` field to the `Priority` struct. ([#3922](https://github.com/getsentry/relay/pull/3922))
+- Extract `user.geo.subregion` for mobile spans. ([#3927](https://github.com/getsentry/relay/pull/3927))
 
 ## 24.7.1
 

diff --git a/relay-dynamic-config/src/defaults.rs b/relay-dynamic-config/src/defaults.rs
@@ -471,6 +471,9 @@ pub fn hardcoded_span_metrics() -> Vec<(GroupKey, Vec<MetricSpec>, Vec<TagMappin
                         Tag::with_key("span.group")
                             .from_field("span.sentry_tags.group")
                             .always(),
+                        Tag::with_key("user.geo.subregion")
+                            .from_field("span.sentry_tags.user.geo.subregion")
+                            .always(),
                         Tag::with_key("device.class")
                             .from_field("span.sentry_tags.device.class")
                             .always(),
@@ -506,6 +509,9 @@ pub fn hardcoded_span_metrics() -> Vec<(GroupKey, Vec<MetricSpec>, Vec<TagMappin
                         Tag::with_key("span.group")
                             .from_field("span.sentry_tags.group")
                             .always(),
+                        Tag::with_key("user.geo.subregion")
+                            .from_field("span.sentry_tags.user.geo.subregion")
+                            .always(),
                         Tag::with_key("device.class")
                             .from_field("span.sentry_tags.device.class")
                             .always(),
@@ -541,6 +547,9 @@ pub fn hardcoded_span_metrics() -> Vec<(GroupKey, Vec<MetricSpec>, Vec<TagMappin
                         Tag::with_key("span.group")
                             .from_field("span.sentry_tags.group")
                             .always(),
+                        Tag::with_key("user.geo.subregion")
+                            .from_field("span.sentry_tags.user.geo.subregion")
+                            .always(),
                         Tag::with_key("device.class")
                             .from_field("span.sentry_tags.device.class")
                             .always(),
@@ -576,6 +585,9 @@ pub fn hardcoded_span_metrics() -> Vec<(GroupKey, Vec<MetricSpec>, Vec<TagMappin
                         Tag::with_key("span.group")
                             .from_field("span.sentry_tags.group")
                             .always(),
+                        Tag::with_key("user.geo.subregion")
+                            .from_field("span.sentry_tags.user.geo.subregion")
+                            .always(),
                         Tag::with_key("device.class")
                             .from_field("span.sentry_tags.device.class")
                             .always(),

diff --git a/relay-server/src/metrics_extraction/event.rs b/relay-server/src/metrics_extraction/event.rs
@@ -1236,6 +1236,15 @@ mod tests {
     const MOBILE_EVENT: &str = r#"
         {
             "type": "transaction",
+            "user": {
+                "id": "user123",
+                "geo": {
+                    "country_code": "US",
+                    "city": "Washington",
+                    "subdivision": "Virginia",
+                    "region": "United States"
+                }
+            },
             "sdk": {"name": "sentry.javascript.react-native"},
             "start_timestamp": "2021-04-26T07:59:01+0100",
             "timestamp": "2021-04-26T08:00:00+0100",