Skip to content

Commit

Permalink
ref(spans): Move span metrics to spans namespace (#2205)
Browse files Browse the repository at this point in the history
  • Loading branch information
iker-barriocanal authored Jun 12, 2023
1 parent f8aca40 commit 8bcaca8
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 54 deletions.
12 changes: 6 additions & 6 deletions relay-server/src/metrics_extraction/spans/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,8 @@ pub(crate) fn extract_span_metrics(
if let Some(user) = event.user.value() {
if let Some(value) = get_eventuser_tag(user) {
metrics.push(Metric::new_mri(
MetricNamespace::Transactions,
"span.user",
MetricNamespace::Spans,
"user",
MetricUnit::None,
MetricValue::set_from_str(&value),
timestamp,
Expand All @@ -222,8 +222,8 @@ pub(crate) fn extract_span_metrics(
// such as sub-transactions. We accept these limitations for
// now.
metrics.push(Metric::new_mri(
MetricNamespace::Transactions,
"span.exclusive_time",
MetricNamespace::Spans,
"exclusive_time",
MetricUnit::Duration(DurationUnit::MilliSecond),
MetricValue::Distribution(*exclusive_time),
timestamp,
Expand All @@ -234,8 +234,8 @@ pub(crate) fn extract_span_metrics(
// The `duration` of a span. This metric also serves as the
// counter metric `throughput`.
metrics.push(Metric::new_mri(
MetricNamespace::Transactions,
"span.duration",
MetricNamespace::Spans,
"duration",
MetricUnit::Duration(DurationUnit::MilliSecond),
MetricValue::Distribution(relay_common::chrono_to_positive_millis(end - start)),
timestamp,
Expand Down
Loading

0 comments on commit 8bcaca8

Please sign in to comment.