-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): Add jvm
debug file type
#2002
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
18b9617
Add new debug file type called jvmbased
adinauer 304302f
update test snapshot
adinauer cef2d01
Merge branch 'master' into feat/new-debug-file-type-jvmbased
adinauer bcf7658
Merge branch 'master' into feat/new-debug-file-type-jvmbased
adinauer 2bc890f
Add changelog
adinauer 2f90684
Merge branch 'master' into feat/new-debug-file-type-jvmbased
adinauer ed63ba1
Rename JvmBased to Jvm
adinauer 02075cb
Use Map::new instead of Object::new
adinauer f36c20c
Update CHANGELOG.md
adinauer 26d9373
Merge branch 'master' into feat/new-debug-file-type-jvmbased
adinauer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,6 +128,12 @@ pub struct Metrics { | |
#[metastructure(field = "ms.processing.proguard")] | ||
pub ms_processing_proguard: Annotated<u64>, | ||
|
||
/// The number of milliseconds Sentry spent resolving sources for a java event. | ||
/// | ||
/// This metric is measured in Sentry and reported in the java processing task. | ||
#[metastructure(field = "ms.processing.jvmbased")] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure, this is needed. |
||
pub ms_processing_jvmbased: Annotated<u64>, | ||
|
||
/// The number of milliseconds sentry spent resolving minified stack traces for a javascript event. | ||
/// | ||
/// This metric is measured in Sentry and reported in the javascript processing task. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rename
JvmBased
toJvm
everywhere, but that is just a personal preference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agreed, this also came up in another PR. Will rename it and update this PR.