fix(spans): Fix name of cache.hit and cache.key field #4408
+137
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikB2014
approved these changes
Dec 18, 2024
Dav1dde
approved these changes
Dec 18, 2024
|
Should there be some sort of test case that needs to be updated/added? |
Converted one of the tests to a snapshot test to make future regressions more obvious. |
jjbayer
commented
Dec 18, 2024
Comment on lines
+73
to
+74
| "cache.hit": "false", | ||
| "cache.key": "[\"my_key\",\"my_key_2\"]", |
There was a problem hiding this comment.
Without the added metastructure attribute, these entries come out as cache_hit and cache_key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #4364,
cache.hitandcache.keydid not serialize into the correct field name.