Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input attributes are masked for elements with "unmask" class #79

Closed
billyvg opened this issue Mar 14, 2023 · 0 comments · Fixed by #81
Closed

Input attributes are masked for elements with "unmask" class #79

billyvg opened this issue Mar 14, 2023 · 0 comments · Fixed by #81
Assignees
@mydea

Comments

@billyvg
Copy link
Member

billyvg commented Mar 14, 2023

When maskAllText is on, attributes are always masked even if the element has a class matching unmaskSelector.

e.g. <input placeholder="This should be unmasked" class="rr-unmask" />
@mydea mydea mentioned this issue Mar 16, 2023
Merged
@mydea mydea closed this as completed in #81 Mar 17, 2023
mydea added a commit that referenced this issue Mar 17, 2023
@mydea @billyvg
fix: Ensure unmaskTextSelector is used for masked attributes (#81)
0eb738a 
Closes #79

---------

Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Ensure unmaskTextSelector is used for masked attributes getsentry/rrweb
2 participants
@billyvg @mydea