Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snapshot): Change to ignore all link[rel="modulepreload"] #228

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Dec 6, 2024

... removes requirement to have as="script" attribute. Also fixes prefetch to extract file extension instead of checking end of string since there can be URL parameters.

... removes requirement to have `as="script"` attribute. Also fixes prefetch to extract file extension instead of checking end of string since there can be URL parameters.
@billyvg billyvg requested a review from a team December 6, 2024 18:59
@billyvg billyvg marked this pull request as ready for review December 9, 2024 17:55
Copy link
Member

@c298lee c298lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing the requirement to have as="script" attribute

@billyvg
Copy link
Member Author

billyvg commented Dec 10, 2024

why are we removing the requirement to have as="script" attribute

modulepreload itself already implies the intent to load a JS module, there's no need to be specific about additional attributes.

@billyvg billyvg merged commit 81d8462 into sentry-v2 Dec 10, 2024
16 checks passed
@billyvg billyvg deleted the fix-snapshot-link-modulepreload-ignore-all branch December 10, 2024 18:52
billyvg added a commit to getsentry/sentry-javascript that referenced this pull request Dec 12, 2024
Includes the following fixes:

- fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226))
- fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227))
- fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg added a commit to getsentry/sentry-javascript that referenced this pull request Dec 12, 2024
Includes the following fixes:

- fix: remote CSS does not get rebuilt properly ([#226](getsentry/rrweb#226))
- fix(snapshot): Set <link> attributes to null for remote CSS ([#227](getsentry/rrweb#227))
- fix(snapshot): Change to ignore all link[rel="modulepreload"] ([#228](getsentry/rrweb#228))
billyvg added a commit to getsentry/sentry-javascript that referenced this pull request Dec 12, 2024
Includes the following fixes:

- fix: remote CSS does not get rebuilt properly
([#226](getsentry/rrweb#226))
- fix(snapshot): Set <link> attributes to null for remote CSS
([#227](getsentry/rrweb#227))
- fix(snapshot): Change to ignore all link[rel="modulepreload"]
([#228](getsentry/rrweb#228))
billyvg added a commit that referenced this pull request Dec 17, 2024
... removes requirement to have `as="script"` attribute. Also fixes
prefetch to extract file extension instead of checking end of string
since there can be URL parameters.
billyvg added a commit that referenced this pull request Dec 17, 2024
... removes requirement to have `as="script"` attribute. Also fixes
prefetch to extract file extension instead of checking end of string
since there can be URL parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants