-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: using Arc<str> instead of String #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though this is a breaking change :-(
In a bunch of places, I was thinking about using IndexSet
instead of manually implementing that same functionality as well.
6c08c44
to
89244e8
Compare
I'm not sure the performance using |
Not sure about the performance aspect of it. I just wanted to clean up the code, because implementing this manually looks out of place. |
OK. Get it. |
|
Maybe we can merge it and refactor it at next. Though it has a break change, but the performance it is important for oxc/swc etc. |
@Swatinem What can I do for merge the pr? Or Could you publish an alpha/beta for this? Thank you. |
That would be the more difficult thing I believe :-D Sentry has some custom automation around publishing to crates.io, and I’m not quite sure we can even do prereleases. I can merge this PR as is, though I would also like to get #77 in, as that also has some breaking changes, to minimize the number of major releases. |
Thank you. @Swatinem Could you publish an new version for them? |
@Swatinem Sorry for ping again. Maybe you missing my response. |
Published Not too happy about not being able to maintain API stability for a longer time frame, but I just have to face reality here :-D |
Here has some unnecessary memory alloc, and the pr intends to fix them.
Here has a example.