Check to see if docker compose exists, else error out #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertdeng123
force-pushed
the
hubertdeng123/check-docker-compose-exists
branch
from
92bc0b9 to
d36e84a
Compare
|
Can you also add a check that the docker command works as well? I noticed that is a common issue for users (e.g. when the daemon isn't running etc) |
|
Yep, can add that too |
27 tasks
BYK
reviewed
Oct 4, 2022
emmatyping
reviewed
Oct 4, 2022
hubertdeng123
force-pushed
the
hubertdeng123/check-docker-compose-exists
branch
from
492db93 to
d507865
Compare
|
Changes implemented! |
emmatyping
approved these changes
Oct 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our most common errors that we're seeing on self-hosted occurs when docker-compose doesn't exist. Our version check then throws an exception.
https://self-hosted.getsentry.net/organizations/self-hosted/issues/16/?query=is%3Aunresolved
This PR adds logic to ensure that we're able to find the version of docker compose and output an error msg to the user when docker compose does not exist.