Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try adding end to end tests using new action #1806

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Try adding end to end tests using new action #1806

merged 4 commits into from
Nov 14, 2022

Conversation

emmatyping
Copy link
Contributor

No description provided.

@emmatyping emmatyping marked this pull request as ready for review November 11, 2022 21:53
@hubertdeng123
Copy link
Member

lgtm, seems like functionality is all there. great job!

@hubertdeng123
Copy link
Member

I think at this point reviewing PR's in the self hosted action repo is probably more helpful haha

@emmatyping
Copy link
Contributor Author

I think at this point reviewing PR's in the self hosted action repo is probably more helpful haha

Unfortunately there is a double dance because you have to update the action repo and the ref/SHA/tag in the action :/

@emmatyping emmatyping merged commit 794b9ff into master Nov 14, 2022
@emmatyping emmatyping deleted the test-e2e branch November 14, 2022 17:31
@chadwhitacre chadwhitacre mentioned this pull request Nov 22, 2022
Closed
17 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hubertdeng123 hubertdeng123 hubertdeng123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmatyping @hubertdeng123