This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
fix desugaring Gson/AGP #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=========================================
Coverage 57.73% 57.73%
Complexity 526 526
=========================================
Files 72 72
Lines 2522 2522
Branches 223 223
=========================================
Hits 1456 1456
Misses 958 958
Partials 108 108Continue to review full report at Codecov.
|
mitsuhiko
approved these changes
Nov 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
make gson retro compatible with older versions of AGP
💡 Motivation and Context
when compiling a project and using the latest version of sentry-android, an error was happening due to:
google/gson#1597
investigation due to:
#171
💚 How did you test it?
compiling a sample project with all the AGP versions >= 3 till the latest one.
📝 Checklist
🔮 Next steps
find a way to compile a sample project with all AGP versions, to be sure that we don't release something which is breaking the build for older versions.