Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add enable capture failed requests #585

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Feb 29, 2024

This flag is enabled by default on iOS where it should be defaulted by false.

This flag will reduce error noises from clients since it'll stop recording Http errors that came from the Native side.
Users should only enable this flag if they do made Native code that does Http Requests.

TEST:

When this flag wasn't set, if a native Http Request error happened, the native SDK creates an event for it.
https://sentry-sdks.sentry.io/issues/5025177828/events/959b6258d9eb4931b196139436996011/?project=5522756

When disabled (the new behaviour), the same event will not be created.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lucas-zimerman lucas-zimerman marked this pull request as ready for review February 29, 2024 22:39
src/options.ts Outdated Show resolved Hide resolved
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you!

@lucas-zimerman lucas-zimerman merged commit b1351a0 into main Mar 5, 2024
7 checks passed
@lucas-zimerman lucas-zimerman deleted the add/enableCaptureFailedRequests branch March 5, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants