Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when files are skipped from uploading due to invalid encoding #2135

Closed
szokeasaurusrex opened this issue Aug 28, 2024 · 0 comments · Fixed by #2146
Closed

Log when files are skipped from uploading due to invalid encoding #2135

szokeasaurusrex opened this issue Aug 28, 2024 · 0 comments · Fixed by #2146
Assignees

Comments

@szokeasaurusrex
Copy link
Member

Implement this request.

Depends on getsentry/symbolic#863, since we need this callback to be present in Symbolic to be able to log when files are skipped.

@szokeasaurusrex szokeasaurusrex self-assigned this Sep 4, 2024
szokeasaurusrex added a commit that referenced this issue Sep 5, 2024
When a file has an invalid (non-UTF-8) encoding, it is skipped from being added to source bundles. Previously, the file was silently skipped. Now, we log when we skip a file.

Fixes #2135
szokeasaurusrex added a commit that referenced this issue Sep 9, 2024
When a file has an invalid (non-UTF-8) encoding, it is skipped from being added to source bundles. Previously, the file was silently skipped. Now, we log when we skip a file.

Fixes #2135
szokeasaurusrex added a commit that referenced this issue Sep 9, 2024
When a file has an invalid (non-UTF-8) encoding, it is skipped from being added to source bundles. Previously, the file was silently skipped. Now, we log when we skip a file.

Fixes #2135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant