test: Run trycmd tests with RUST_BACKTRACE=0
#2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our `trycmd` tests assume that no backtrace is printed in the test commands output, even when an error is supposed to occur. `RUST_BACKTRACE=0` appears to be set in CI, but this becomes a problem running tests locally, where tests sometimes fail when the local environmnent has `RUST_BACKTRACE=0`. Note that backtraces are still logged tracing back to the error that caused the test failure. But, if we are testing that a specific command which we expect to fail has a certain output, this change ensures that regardless of the outside environment, we don't get a backtrace _in the test output_, as this could fail the test.
loewenheim
approved these changes
Nov 8, 2024
szokeasaurusrex
deleted the
szokeasaurusrex/run-tests-rust-backtrace-0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our
trycmdtests assume that no backtrace is printed in the test commands output, even when an error is supposed to occur.RUST_BACKTRACE=0appears to be set in CI, but this becomes a problem running tests locally, where tests sometimes fail when the local environmnent hasRUST_BACKTRACE=1.Note that backtraces are still logged tracing back to the error that caused the test failure. But, if we are testing that a specific command which we expect to fail has a certain output, this change ensures that regardless of the outside environment, we don't get a backtrace in the test output, as this could fail the test.