Skip to content

Commit

Permalink
impr: Align SDK dispatch queue names (#4442)
Browse files Browse the repository at this point in the history
All dispatch queues now start with the prefix .
  • Loading branch information
philipphofmann authored Oct 16, 2024
1 parent 95331f3 commit 149877e
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ via the option `swizzleClassNameExclude`.
- Serializing profile on a BG Thread (#4377) to avoid potentially slightly blocking the main thread.
- Session Replay performance for SwiftUI (#4419)
- Speed up getBinaryImages (#4435) for finishing transactions and capturing events
- Align SDK dispatch queue names (#4442) to start with `io.sentry`
- Use UInts in envelope deserialization (#4441)

## 8.38.0
Expand Down
2 changes: 1 addition & 1 deletion Sources/Sentry/SentryDispatchQueueWrapper.m
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ - (instancetype)init
// iOS 9 we need to manually add the autoreleasepool.
dispatch_queue_attr_t attributes = dispatch_queue_attr_make_with_qos_class(
DISPATCH_QUEUE_SERIAL, DISPATCH_QUEUE_PRIORITY_DEFAULT, 0);
self = [self initWithName:"sentry-default" attributes:attributes];
self = [self initWithName:"io.sentry.default" attributes:attributes];
return self;
}

Expand Down
2 changes: 1 addition & 1 deletion Sources/Sentry/SentryPerformanceTrackingIntegration.m
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ - (BOOL)installWithOptions:(SentryOptions *)options
dispatch_queue_attr_t attributes = dispatch_queue_attr_make_with_qos_class(
DISPATCH_QUEUE_SERIAL, DISPATCH_QUEUE_PRIORITY_HIGH, 0);
SentryDispatchQueueWrapper *dispatchQueue =
[[SentryDispatchQueueWrapper alloc] initWithName:"sentry-ui-view-controller-swizzling"
[[SentryDispatchQueueWrapper alloc] initWithName:"io.sentry.ui-view-controller-swizzling"
attributes:attributes];

SentrySubClassFinder *subClassFinder = [[SentrySubClassFinder alloc]
Expand Down
2 changes: 1 addition & 1 deletion Sources/Sentry/SentryTransportFactory.m
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ @implementation SentryTransportFactory
dispatch_queue_attr_t attributes = dispatch_queue_attr_make_with_qos_class(
DISPATCH_QUEUE_SERIAL, DISPATCH_QUEUE_PRIORITY_LOW, 0);
SentryDispatchQueueWrapper *dispatchQueueWrapper =
[[SentryDispatchQueueWrapper alloc] initWithName:"sentry-http-transport"
[[SentryDispatchQueueWrapper alloc] initWithName:"io.sentry.http-transport"
attributes:attributes];

SentryNSURLRequestBuilder *requestBuilder = [[SentryNSURLRequestBuilder alloc] init];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ - (BOOL)installWithOptions:(SentryOptions *)options
dispatch_queue_attr_t attributes = dispatch_queue_attr_make_with_qos_class(
DISPATCH_QUEUE_SERIAL, DISPATCH_QUEUE_PRIORITY_HIGH, 0);
SentryDispatchQueueWrapper *dispatchQueueWrapper =
[[SentryDispatchQueueWrapper alloc] initWithName:"sentry-out-of-memory-tracker"
[[SentryDispatchQueueWrapper alloc] initWithName:"io.sentry.watchdog-termination-tracker"
attributes:attributes];

SentryFileManager *fileManager = [[[SentrySDK currentHub] getClient] fileManager];
Expand Down

0 comments on commit 149877e

Please sign in to comment.