Apply suggestions from code review

getsentry · Oct 8, 2024 · 3f5353a · 3f5353a
1 parent bd12433
commit 3f5353a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/benchmarking.yml b/.github/workflows/benchmarking.yml
@@ -126,7 +126,7 @@ jobs:
           MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
           MATCH_USERNAME: ${{ secrets.MATCH_USERNAME }}
       - name: Build Framework
-        run: ./scripts/build-xcframework.sh reduced
+        run: ./scripts/build-xcframework.sh iOSOnly
 
       - name: Archive build log if failed
         uses: actions/upload-artifact@v4

diff --git a/scripts/build-xcframework.sh b/scripts/build-xcframework.sh
@@ -4,7 +4,7 @@ set -eou pipefail
 
 args="${1:-}"
 
-if [ "$args" = "reduced" ]; then
+if [ "$args" = "iOSOnly" ]; then
     sdks=( iphoneos iphonesimulator )
 else
     sdks=( iphoneos iphonesimulator macosx appletvos appletvsimulator watchos watchsimulator xros xrsimulator )
@@ -87,7 +87,7 @@ generate_xcframework() {
         OTHER_LDFLAGS="-Wl,-make_mergeable"
     fi
 
-    if [ "$args" != "reduced" ]; then
+    if [ "$args" != "iOSOnly" ]; then
         #Create framework for mac catalyst
         xcodebuild \
             -project Sentry.xcodeproj/ \
@@ -122,7 +122,7 @@ generate_xcframework() {
 
 generate_xcframework "Sentry" "-Dynamic"
 
-if [ "$args" != "reduced" ]; then
+if [ "$args" != "iOSOnly" ]; then
     generate_xcframework "Sentry" "" staticlib
 
     generate_xcframework "SentrySwiftUI"