swizzleClassNameExcludes is ignored for loadView

[philipphofmann]

Description

We swizzle the loadView method of the UIViewControllernot the individual view controllers because of some edge cases with nib files.

sentry-cocoa/Sources/Sentry/SentryUIViewControllerSwizzling.m

Lines 306 to 322 in 8c38fb1

	/**
	* We need to swizzle @c -[UIViewController @c loadView] because we can't do it for controllers that
	* use Nib files (see @c swizzleLoadView for more information).
	* @c SentryUIViewControllerPerformanceTracker makes sure we don't get two spans
	* if the @c -[loadView] of an actual @c UIViewController is swizzled.
	*/
	- (void)swizzleUIViewController
	{
	SEL selector = NSSelectorFromString(@"loadView");
	SentrySwizzleInstanceMethod(UIViewController.class, selector, SentrySWReturnType(void),
	SentrySWArguments(), SentrySWReplacement({
	[SentryUIViewControllerPerformanceTracker.shared
	viewControllerLoadView:self
	callbackToOrigin:^{ SentrySWCallOriginal(); }];
	}),
	SentrySwizzleModeOncePerClassAndSuperclasses, (void *)selector);
	}

So the SentryUIViewControllerPerformanceTracker.viewControllerLoadView checks the inAppLogic, but doesn't check the swizzleClassNameExcludes.

sentry-cocoa/Sources/Sentry/SentryUIViewControllerPerformanceTracker.m

Lines 61 to 69 in 8c38fb1

	- (void)viewControllerLoadView:(UIViewController *)controller
	callbackToOrigin:(void (^)(void))callbackToOrigin
	{
	if (![self.inAppLogic isClassInApp:[controller class]]) {
	SENTRY_LOG_DEBUG(
	@"Won't track view controller that is not part of the app bundle: %@.", controller);
	callbackToOrigin();
	return;
	}

So when adding a UIViewController to the swizzleClassNameExcludes it doesn't work. We should also check the swizzleClassNameExcludes in the SentryUIViewControllerPerformanceTracker.viewControllerLoadView.