-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updating AppHang state on main thread #2793
Conversation
Move updating the app hang state to a background thread for anrStopped.
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bd2afa6 | 1192.31 ms | 1210.37 ms | 18.05 ms |
7fb7afb | 1235.00 ms | 1256.81 ms | 21.81 ms |
3389927 | 1230.12 ms | 1238.04 ms | 7.92 ms |
0dedab7 | 1221.26 ms | 1235.34 ms | 14.08 ms |
ff09c7e | 1240.94 ms | 1262.66 ms | 21.72 ms |
fdfe96b | 1227.90 ms | 1242.56 ms | 14.66 ms |
f8fc36d | 1226.31 ms | 1247.80 ms | 21.49 ms |
4d6f273 | 1195.63 ms | 1232.22 ms | 36.59 ms |
25bcc50 | 1237.69 ms | 1258.40 ms | 20.71 ms |
8cb9355 | 1225.23 ms | 1231.22 ms | 5.99 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bd2afa6 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
7fb7afb | 20.76 KiB | 419.69 KiB | 398.94 KiB |
3389927 | 20.76 KiB | 427.23 KiB | 406.46 KiB |
0dedab7 | 20.76 KiB | 420.00 KiB | 399.24 KiB |
ff09c7e | 20.76 KiB | 427.76 KiB | 407.00 KiB |
fdfe96b | 20.76 KiB | 419.70 KiB | 398.95 KiB |
f8fc36d | 20.76 KiB | 419.70 KiB | 398.94 KiB |
4d6f273 | 20.76 KiB | 426.93 KiB | 406.17 KiB |
25bcc50 | 20.76 KiB | 427.23 KiB | 406.46 KiB |
8cb9355 | 20.76 KiB | 419.70 KiB | 398.95 KiB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2793 +/- ##
==========================================
- Coverage 81.23% 81.20% -0.03%
==========================================
Files 257 257
Lines 24206 24204 -2
Branches 10776 10774 -2
==========================================
- Hits 19664 19656 -8
- Misses 4044 4050 +6
Partials 498 498
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just not sure about whether we want to delay gathering stack traces. It might remove our own code frames, but might make the feature less useful in general.
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Updating AppHang state on main thread ([#2793](https://github.com/getsentry/sentry-cocoa/pull/2793)) If none of the above apply, you can opt out of this check by adding |
📜 Description
Move updating the app hang state to a background thread for anrStopped.
💡 Motivation and Context
It came up while investigating #2791
💚 How did you test it?
Unit tests and on a real device.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps