Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use serial dispatch queue for invocations #3981

Merged
merged 1 commit into from
May 15, 2024

Conversation

philipphofmann
Copy link
Member

Using the barrier flag with the concurrent attribute is similar to using a serial dispatch queue, so we can use a serial dispatch queue instead to simplify the syntax.

#skip-changelog

Using the barrier flag with the concurrent attribute is similar to using
a serial dispatch queue, so we can use a serial dispatch queue instead
to simplify the syntax.
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.859%. Comparing base (1ac58a6) to head (8b0ecd7).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3981       +/-   ##
=============================================
- Coverage   90.870%   90.859%   -0.012%     
=============================================
  Files          594       594               
  Lines        46083     46082        -1     
  Branches     16442     16441        -1     
=============================================
- Hits         41876     41870        -6     
- Misses        4027      4142      +115     
+ Partials       180        70      -110     
Files Coverage Δ
SentryTestUtils/Invocations.swift 87.500% <66.666%> (ø)

... and 30 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ac58a6...8b0ecd7. Read the comment docs.

@philipphofmann philipphofmann merged commit 9692592 into main May 15, 2024
21 of 23 checks passed
@philipphofmann philipphofmann deleted the test/invocations-serial-dispatch-queu branch May 15, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants