fix: iOS warning of missing method channel callback setReplayConfig (#…

…2478)
getsentry · Dec 11, 2024 · 20a5bce · 20a5bce
1 parent ab99a31
commit 20a5bce
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/flutter/lib/src/native/cocoa/sentry_native_cocoa.dart b/flutter/lib/src/native/cocoa/sentry_native_cocoa.dart
@@ -1,10 +1,12 @@
+import 'dart:async';
 import 'dart:ffi';
 import 'dart:typed_data';
 import 'dart:ui';
 
 import 'package:meta/meta.dart';
 
 import '../../../sentry_flutter.dart';
+import '../../replay/replay_config.dart';
 import '../../screenshot/recorder.dart';
 import '../../screenshot/recorder_config.dart';
 import '../sentry_native_channel.dart';
@@ -68,6 +70,11 @@ class SentryNativeCocoa extends SentryNativeChannel {
     return super.init(hub);
   }
 
+  @override
+  FutureOr<void> setReplayConfig(ReplayConfig config) {
+    // Note: unused on iOS.
+  }
+
   @override
   int? startProfiler(SentryId traceId) => tryCatchSync('startProfiler', () {
         final cSentryId = cocoa.SentryId1.alloc(_lib)

diff --git a/flutter/lib/src/native/sentry_native_channel.dart b/flutter/lib/src/native/sentry_native_channel.dart
@@ -221,7 +221,7 @@ class SentryNativeChannel
   bool get supportsReplay => false;
 
   @override
-  Future<void> setReplayConfig(ReplayConfig config) =>
+  FutureOr<void> setReplayConfig(ReplayConfig config) =>
       channel.invokeMethod('setReplayConfig', {
         'width': config.width,
         'height': config.height,

diff --git a/flutter/test/sentry_native_channel_test.dart b/flutter/test/sentry_native_channel_test.dart
@@ -335,12 +335,16 @@ void main() {
             ReplayConfig(width: 1.1, height: 2.2, frameRate: 3, bitRate: 4);
         await sut.setReplayConfig(config);
 
-        verify(channel.invokeMethod('setReplayConfig', {
-          'width': config.width,
-          'height': config.height,
-          'frameRate': config.frameRate,
-          'bitRate': config.bitRate,
-        }));
+        if (mockPlatform.isAndroid) {
+          verify(channel.invokeMethod('setReplayConfig', {
+            'width': config.width,
+            'height': config.height,
+            'frameRate': config.frameRate,
+            'bitRate': config.bitRate,
+          }));
+        } else {
+          verifyNever(channel.invokeMethod('setReplayConfig', any));
+        }
       });
 
       test('captureReplay', () async {