Merge branch 'main' into fix/ttid_ttfd_timing_issue

getsentry · Oct 1, 2024 · 30db7b8 · 30db7b8
2 parents c4af7e4 + 8c0b6dc
commit 30db7b8
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 1,006 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,7 +5,7 @@
 ### Features
 
 - Emit `transaction.data` inside `contexts.trace.data` ([#2284](https://github.com/getsentry/sentry-dart/pull/2284))
-- Blocking app starts if "appLaunchedInForeground" is false. (Android only) ([#2291](https://github.com/getsentry/sentry-dart/pull/2291)
+- Blocking app starts if "appLaunchedInForeground" is false. (Android only) ([#2291](https://github.com/getsentry/sentry-dart/pull/2291))
 
 ### Enhancements
 
@@ -21,6 +21,11 @@
 - Rounding error used on frames.total and reject frame measurements if frames.total is less than frames.slow or frames.frozen ([#2308](https://github.com/getsentry/sentry-dart/pull/2308))
 - iOS replay integration when only `onErrorSampleRate` is specified ([#2306](https://github.com/getsentry/sentry-dart/pull/2306))
 
+### Deprecate
+
+- Metrics API ([#2312](https://github.com/getsentry/sentry-dart/pull/2312))
+  - Learn more: https://sentry.zendesk.com/hc/en-us/articles/26369339769883-Metrics-Beta-Coming-to-an-End
+
 ## 8.9.0
 
 ### Features

diff --git a/dart/lib/src/hub.dart b/dart/lib/src/hub.dart
@@ -44,6 +44,8 @@ class Hub {
   late final MetricsApi _metricsApi;
 
   @internal
+  @Deprecated(
+      'Metrics will be deprecated and removed in the next major release. Sentry will reject all metrics sent after October 7, 2024. Learn more: https://sentry.zendesk.com/hc/en-us/articles/26369339769883-Upcoming-API-Changes-to-Metrics')
   MetricsApi get metricsApi => _metricsApi;
 
   @internal

diff --git a/dart/lib/src/hub_adapter.dart b/dart/lib/src/hub_adapter.dart
@@ -28,6 +28,7 @@ class HubAdapter implements Hub {
 
   @override
   @internal
+  // ignore: deprecated_member_use_from_same_package
   MetricsApi get metricsApi => Sentry.currentHub.metricsApi;
 
   factory HubAdapter() {

diff --git a/dart/lib/src/sentry.dart b/dart/lib/src/sentry.dart
@@ -316,6 +316,8 @@ class Sentry {
   static ISentrySpan? getSpan() => _hub.getSpan();
 
   /// Gets access to the metrics API for the current hub.
+  @Deprecated(
+      'Metrics will be deprecated and removed in the next major release. Sentry will reject all metrics sent after October 7, 2024. Learn more: https://sentry.zendesk.com/hc/en-us/articles/26369339769883-Upcoming-API-Changes-to-Metrics')
   static MetricsApi metrics() => _hub.metricsApi;
 
   @internal

diff --git a/dart/test/metrics/local_metrics_aggregator_test.dart b/dart/test/metrics/local_metrics_aggregator_test.dart