fix: update android calls after SDK update (#2211)

* fix: update android calls after SDK update * ktlint
getsentry · Aug 2, 2024 · 648f8bc · 648f8bc
1 parent 0eb16e1
commit 648f8bc
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 25 deletions.
diff --git a/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt b/flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt
@@ -83,7 +83,7 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
       "loadContexts" -> loadContexts(result)
       "displayRefreshRate" -> displayRefreshRate(result)
       "addReplayScreenshot" -> addReplayScreenshot(call.argument("path"), call.argument("timestamp"), result)
-      "sendReplayForEvent" -> sendReplayForEvent(call.argument("eventId"), call.argument("isCrash"), result)
+      "captureReplay" -> captureReplay(call.argument("isCrash"), result)
       else -> result.notImplemented()
     }
   }
@@ -555,16 +555,15 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
     result.success("")
   }
 
-  private fun sendReplayForEvent(
-    eventId: String?,
+  private fun captureReplay(
     isCrash: Boolean?,
     result: Result,
   ) {
-    if (eventId == null || isCrash == null) {
+    if (isCrash == null) {
       result.error("5", "Arguments are null", null)
       return
     }
-    replay.sendReplay(isCrash, eventId, null)
+    replay.captureReplay(isCrash)
     result.success(replay.getReplayId().toString())
   }
 }
diff --git a/flutter/lib/src/event_processor/replay_event_processor.dart b/flutter/lib/src/event_processor/replay_event_processor.dart
@@ -15,7 +15,7 @@ class ReplayEventProcessor implements EventProcessor {
         event.exceptions?.isNotEmpty == true) {
       final isCrash =
           event.exceptions!.any((e) => e.mechanism?.handled == false);
-      await _binding.sendReplayForEvent(event.eventId, isCrash);
+      await _binding.captureReplay(isCrash);
     }
     return event;
   }

diff --git a/flutter/lib/src/native/sentry_native_binding.dart b/flutter/lib/src/native/sentry_native_binding.dart
@@ -58,5 +58,5 @@ abstract class SentryNativeBinding {
 
   Future<void> resumeAppHangTracking();
 
-  Future<SentryId> sendReplayForEvent(SentryId eventId, bool isCrash);
+  Future<SentryId> captureReplay(bool isCrash);
 }
diff --git a/flutter/lib/src/native/sentry_native_channel.dart b/flutter/lib/src/native/sentry_native_channel.dart
@@ -198,9 +198,8 @@ class SentryNativeChannel
       channel.invokeMethod('resumeAppHangTracking');
 
   @override
-  Future<SentryId> sendReplayForEvent(SentryId eventId, bool isCrash) =>
-      channel.invokeMethod('sendReplayForEvent', {
-        'eventId': eventId.toString(),
+  Future<SentryId> captureReplay(bool isCrash) =>
+      channel.invokeMethod('captureReplay', {
         'isCrash': isCrash,
       }).then((value) => SentryId.fromId(value as String));
 }
diff --git a/flutter/test/mocks.mocks.dart b/flutter/test/mocks.mocks.dart
@@ -1364,26 +1364,16 @@ class MockSentryNativeBinding extends _i1.Mock
       ) as _i7.Future<void>);
 
   @override
-  _i7.Future<_i2.SentryId> sendReplayForEvent(
-    _i2.SentryId? eventId,
-    bool? isCrash,
-  ) =>
-      (super.noSuchMethod(
+  _i7.Future<_i2.SentryId> captureReplay(bool? isCrash) => (super.noSuchMethod(
         Invocation.method(
-          #sendReplayForEvent,
-          [
-            eventId,
-            isCrash,
-          ],
+          #captureReplay,
+          [isCrash],
         ),
         returnValue: _i7.Future<_i2.SentryId>.value(_FakeSentryId_5(
           this,
           Invocation.method(
-            #sendReplayForEvent,
-            [
-              eventId,
-              isCrash,
-            ],
+            #captureReplay,
+            [isCrash],
           ),
         )),
       ) as _i7.Future<_i2.SentryId>);